Write slot as atomic batch #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
bkolad
approved these changes
Jun 21, 2023
|
@preston-evans98 Do we have a test in main or this branch which has failing case? Otherwise we are blind. Maybe this PR should be opened against #403, and merged there first? |
neysofu
pushed a commit
that referenced
this pull request
Jun 27, 2023
* Write slot as atomic batch * Remove TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit updates the ledger DB so that all components of a slot are written as batch. This should both improve efficiency and eliminate some potential concurrency bugs.
Linked Issues
Testing
Existing unit tests pass. cc @theochap @citizen-stig - let's see if we can reproduce the issue from #417 after this change or not